Files
coredns/plugin/transfer/notify.go
Ncesam 99b683aa41 plugin/transfer: collect all notify errors instead of shadowing (#8283)
* plugin/transfer: collect all notify errors instead of shadowing

Signed-off-by: ncesam <rybushkin09@bk.ru>

* plugin/transfer: add regression test for notify multiple failures

Signed-off-by: ncesam <rybushkin09@bk.ru>

---------

Signed-off-by: ncesam <rybushkin09@bk.ru>
2026-07-15 18:05:01 -07:00

70 lines
1.5 KiB
Go

package transfer
import (
"errors"
"fmt"
"net"
"github.com/coredns/coredns/plugin/pkg/rcode"
"github.com/miekg/dns"
)
// Notify will send notifies to all configured to hosts IP addresses. The string zone must be lowercased.
func (t *Transfer) Notify(zone string) error {
if t == nil { // t might be nil, mostly expected in tests, so intercept and to a noop in that case
return nil
}
m := new(dns.Msg)
m.SetNotify(zone)
x := longestMatch(t.xfrs, zone)
if x == nil {
// return without error if there is no matching zone
return nil
}
c := notifyClient(x)
var errs error
for _, t := range x.to {
if t == "*" {
continue
}
if err := sendNotify(c, m, t); err != nil {
errs = errors.Join(errs, err)
}
}
log.Debugf("Sent notifies for zone %q to %v", zone, x.to)
return errs
}
func notifyClient(x *xfr) *dns.Client {
c := new(dns.Client)
if x != nil && x.source != nil {
c.Dialer = &net.Dialer{LocalAddr: &net.UDPAddr{IP: x.source}}
}
return c
}
func sendNotify(c *dns.Client, m *dns.Msg, s string) error {
var err error
var ret *dns.Msg
code := dns.RcodeServerFailure
for range 3 {
ret, _, err = c.Exchange(m, s)
if err != nil {
continue
}
code = ret.Rcode
if code == dns.RcodeSuccess {
return nil
}
}
if err != nil {
return fmt.Errorf("notify for zone %q was not accepted by %q: %q", m.Question[0].Name, s, err)
}
return fmt.Errorf("notify for zone %q was not accepted by %q: rcode was %q", m.Question[0].Name, s, rcode.ToString(code))
}