mirror of
				https://github.com/coredns/coredns.git
				synced 2025-11-03 02:33:21 -05:00 
			
		
		
		
	Cache the size and the do bit whenever someone asked for it. We can probably add more: PASS BenchmarkStateDo-4 100000000 11.9 ns/op BenchmarkStateSize-4 5000000 265 ns/op ok github.com/miekg/coredns/middleware 2.828s PASS BenchmarkStateDo-4 1000000000 2.86 ns/op BenchmarkStateSize-4 500000000 3.10 ns/op ok github.com/miekg/coredns/middleware 5.032s This PR also includes some testing cleanups as well.
		
			
				
	
	
		
			155 lines
		
	
	
		
			4.4 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			155 lines
		
	
	
		
			4.4 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
// +build etcd
 | 
						|
 | 
						|
// tests mx and txt records
 | 
						|
 | 
						|
package etcd
 | 
						|
 | 
						|
// etcd needs to be running on http://127.0.0.1:2379
 | 
						|
// *and* needs connectivity to the internet for remotely resolving
 | 
						|
// names.
 | 
						|
 | 
						|
import (
 | 
						|
	"sort"
 | 
						|
	"testing"
 | 
						|
 | 
						|
	"github.com/miekg/coredns/middleware"
 | 
						|
	"github.com/miekg/coredns/middleware/etcd/msg"
 | 
						|
	coretest "github.com/miekg/coredns/middleware/testing"
 | 
						|
 | 
						|
	"github.com/miekg/dns"
 | 
						|
)
 | 
						|
 | 
						|
func TestOtherLookup(t *testing.T) {
 | 
						|
	for _, serv := range servicesOther {
 | 
						|
		set(t, etc, serv.Key, 0, serv)
 | 
						|
		defer delete(t, etc, serv.Key)
 | 
						|
	}
 | 
						|
	for _, tc := range dnsTestCasesOther {
 | 
						|
		m := tc.Msg()
 | 
						|
 | 
						|
		rec := middleware.NewResponseRecorder(&coretest.ResponseWriter{})
 | 
						|
		_, err := etc.ServeDNS(ctx, rec, m)
 | 
						|
		if err != nil {
 | 
						|
			t.Errorf("expected no error, got %v\n", err)
 | 
						|
			return
 | 
						|
		}
 | 
						|
		resp := rec.Msg()
 | 
						|
 | 
						|
		sort.Sort(coretest.RRSet(resp.Answer))
 | 
						|
		sort.Sort(coretest.RRSet(resp.Ns))
 | 
						|
		sort.Sort(coretest.RRSet(resp.Extra))
 | 
						|
 | 
						|
		if resp.Rcode != tc.Rcode {
 | 
						|
			t.Errorf("rcode is %q, expected %q", dns.RcodeToString[resp.Rcode], dns.RcodeToString[tc.Rcode])
 | 
						|
			t.Logf("%v\n", resp)
 | 
						|
			continue
 | 
						|
		}
 | 
						|
 | 
						|
		if len(resp.Answer) != len(tc.Answer) {
 | 
						|
			t.Errorf("answer for %q contained %d results, %d expected", tc.Qname, len(resp.Answer), len(tc.Answer))
 | 
						|
			t.Logf("%v\n", resp)
 | 
						|
			continue
 | 
						|
		}
 | 
						|
		if len(resp.Ns) != len(tc.Ns) {
 | 
						|
			t.Errorf("authority for %q contained %d results, %d expected", tc.Qname, len(resp.Ns), len(tc.Ns))
 | 
						|
			t.Logf("%v\n", resp)
 | 
						|
			continue
 | 
						|
		}
 | 
						|
		if len(resp.Extra) != len(tc.Extra) {
 | 
						|
			t.Errorf("additional for %q contained %d results, %d expected", tc.Qname, len(resp.Extra), len(tc.Extra))
 | 
						|
			t.Logf("%v\n", resp)
 | 
						|
			continue
 | 
						|
		}
 | 
						|
 | 
						|
		if !coretest.CheckSection(t, tc, coretest.Answer, resp.Answer) {
 | 
						|
			t.Logf("%v\n", resp)
 | 
						|
		}
 | 
						|
		if !coretest.CheckSection(t, tc, coretest.Ns, resp.Ns) {
 | 
						|
			t.Logf("%v\n", resp)
 | 
						|
 | 
						|
		}
 | 
						|
		if !coretest.CheckSection(t, tc, coretest.Extra, resp.Extra) {
 | 
						|
			t.Logf("%v\n", resp)
 | 
						|
		}
 | 
						|
	}
 | 
						|
}
 | 
						|
 | 
						|
// Note the key is encoded as DNS name, while in "reality" it is a etcd path.
 | 
						|
var servicesOther = []*msg.Service{
 | 
						|
	{Host: "dev.server1", Port: 8080, Key: "a.server1.dev.region1.skydns.test."},
 | 
						|
 | 
						|
	// mx
 | 
						|
	{Host: "mx.skydns.test", Priority: 50, Mail: true, Key: "a.mail.skydns.test."},
 | 
						|
	{Host: "mx.miek.nl", Priority: 50, Mail: true, Key: "b.mail.skydns.test."},
 | 
						|
	{Host: "a.ipaddr.skydns.test", Priority: 30, Mail: true, Key: "a.mx.skydns.test."},
 | 
						|
 | 
						|
	{Host: "a.ipaddr.skydns.test", Mail: true, Key: "a.mx2.skydns.test."},
 | 
						|
	{Host: "b.ipaddr.skydns.test", Mail: true, Key: "b.mx2.skydns.test."},
 | 
						|
 | 
						|
	{Host: "172.16.1.1", Key: "a.ipaddr.skydns.test."},
 | 
						|
	{Host: "172.16.1.2", Key: "b.ipaddr.skydns.test."},
 | 
						|
 | 
						|
	// txt
 | 
						|
	{Text: "abc", Key: "a1.txt.skydns.test."},
 | 
						|
	{Text: "abc abc", Key: "a2.txt.skydns.test."},
 | 
						|
 | 
						|
	// duplicate ip address
 | 
						|
	{Host: "10.11.11.10", Key: "http.multiport.http.skydns.test.", Port: 80},
 | 
						|
	{Host: "10.11.11.10", Key: "https.multiport.http.skydns.test.", Port: 443},
 | 
						|
}
 | 
						|
 | 
						|
var dnsTestCasesOther = []coretest.Case{
 | 
						|
	// MX Tests
 | 
						|
	{
 | 
						|
		// NODATA as this is not an Mail: true record.
 | 
						|
		Qname: "a.server1.dev.region1.skydns.test.", Qtype: dns.TypeMX,
 | 
						|
		Ns: []dns.RR{
 | 
						|
			coretest.SOA("skydns.test. 300 SOA ns.dns.skydns.test. hostmaster.skydns.test. 0 0 0 0 0"),
 | 
						|
		},
 | 
						|
	},
 | 
						|
	{
 | 
						|
		Qname: "a.mail.skydns.test.", Qtype: dns.TypeMX,
 | 
						|
		Answer: []dns.RR{coretest.MX("a.mail.skydns.test. 300 IN MX 50 mx.skydns.test.")},
 | 
						|
		Extra: []dns.RR{
 | 
						|
			coretest.A("a.ipaddr.skydns.test.	300	IN	A	172.16.1.1"),
 | 
						|
			coretest.CNAME("mx.skydns.test.	300	IN	CNAME	a.ipaddr.skydns.test."),
 | 
						|
		},
 | 
						|
	},
 | 
						|
	{
 | 
						|
		Qname: "mx2.skydns.test.", Qtype: dns.TypeMX,
 | 
						|
		Answer: []dns.RR{
 | 
						|
			coretest.MX("mx2.skydns.test. 300 IN MX 10 a.ipaddr.skydns.test."),
 | 
						|
			coretest.MX("mx2.skydns.test. 300 IN MX 10 b.ipaddr.skydns.test."),
 | 
						|
		},
 | 
						|
		Extra: []dns.RR{
 | 
						|
			coretest.A("a.ipaddr.skydns.test. 300 A 172.16.1.1"),
 | 
						|
			coretest.A("b.ipaddr.skydns.test. 300 A 172.16.1.2"),
 | 
						|
		},
 | 
						|
	},
 | 
						|
	// Txt
 | 
						|
	{
 | 
						|
		Qname: "a1.txt.skydns.test.", Qtype: dns.TypeTXT,
 | 
						|
		Answer: []dns.RR{
 | 
						|
			coretest.TXT("a1.txt.skydns.test. 300 IN TXT \"abc\""),
 | 
						|
		},
 | 
						|
	},
 | 
						|
	{
 | 
						|
		Qname: "a2.txt.skydns.test.", Qtype: dns.TypeTXT,
 | 
						|
		Answer: []dns.RR{
 | 
						|
			coretest.TXT("a2.txt.skydns.test. 300 IN TXT \"abc abc\""),
 | 
						|
		},
 | 
						|
	},
 | 
						|
	{
 | 
						|
		Qname: "txt.skydns.test.", Qtype: dns.TypeTXT,
 | 
						|
		Answer: []dns.RR{
 | 
						|
			coretest.TXT("txt.skydns.test. 300 IN TXT \"abc abc\""),
 | 
						|
			coretest.TXT("txt.skydns.test. 300 IN TXT \"abc\""),
 | 
						|
		},
 | 
						|
	},
 | 
						|
	// Duplicate IP address test
 | 
						|
	{
 | 
						|
		Qname: "multiport.http.skydns.test.", Qtype: dns.TypeA,
 | 
						|
		Answer: []dns.RR{coretest.A("multiport.http.skydns.test. 300 IN A 10.11.11.10")},
 | 
						|
	},
 | 
						|
}
 |