mirror of
				https://github.com/coredns/coredns.git
				synced 2025-11-03 18:53:13 -05:00 
			
		
		
		
	* plugin/metrics: still need nil check for shutdown the second prometheus statement will trigger: (on control-C) [signal SIGSEGV: segmentation violation code=0x1 addr=0x28 pc=0x94f45a] goroutine 25 [running]: github.com/coredns/coredns/plugin/metrics.(*Metrics).OnShutdown(0xc420252000, 0x0, 0x0) /home/miek/g/src/github.com/coredns/coredns/plugin/metrics/metrics.go:107 +0x2a github.com/coredns/coredns/plugin/metrics.(*Metrics).OnShutdown-fm(0x0, 0x0) /home/miek/g/src/github.com/coredns/coredns/plugin/metrics/setup.go:39 +0x2a github.com/mholt/caddy.(*Instance).ShutdownCallbacks(0xc4202c81e0, 0x0, 0x0, 0x0) /home/miek/g/src/github.com/mholt/caddy/caddy.go:164 +0xb3 github.com/mholt/caddy.allShutdownCallbacks(0x1743935, 0x8, 0x14a1b40) /home/miek/g/src/github.com/mholt/caddy/sigtrap.go:95 +0x10d github.com/mholt/caddy.executeShutdownCallbacks.func1() /home/miek/g/src/github.com/mholt/caddy/sigtrap.go:75 +0x8f sync.(*Once).Do(0x2256b80, 0xc42036df88) /home/miek/upstream/go/src/sync/once.go:44 +0xbe github.com/mholt/caddy.executeShutdownCallbacks(0x174033f, 0x6, 0x0) /home/miek/g/src/github.com/mholt/caddy/sigtrap.go:71 +0x73 github.com/mholt/caddy.trapSignalsCrossPlatform.func1.1() /home/miek/g/src/github.com/mholt/caddy/sigtrap.go:61 +0x36 created by github.com/mholt/caddy.trapSignalsCrossPlatform.func1 /home/miek * comments on why
		
			
				
	
	
		
			135 lines
		
	
	
		
			3.4 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			135 lines
		
	
	
		
			3.4 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
// Package metrics implement a handler and plugin that provides Prometheus metrics.
 | 
						|
package metrics
 | 
						|
 | 
						|
import (
 | 
						|
	"log"
 | 
						|
	"net"
 | 
						|
	"net/http"
 | 
						|
	"os"
 | 
						|
	"runtime"
 | 
						|
	"sync"
 | 
						|
 | 
						|
	"github.com/coredns/coredns/coremain"
 | 
						|
	"github.com/coredns/coredns/plugin"
 | 
						|
	"github.com/coredns/coredns/plugin/metrics/vars"
 | 
						|
	"github.com/prometheus/client_golang/prometheus"
 | 
						|
	"github.com/prometheus/client_golang/prometheus/promhttp"
 | 
						|
)
 | 
						|
 | 
						|
// Metrics holds the prometheus configuration. The metrics' path is fixed to be /metrics
 | 
						|
type Metrics struct {
 | 
						|
	Next plugin.Handler
 | 
						|
	Addr string
 | 
						|
	Reg  *prometheus.Registry
 | 
						|
	ln   net.Listener
 | 
						|
	mux  *http.ServeMux
 | 
						|
 | 
						|
	zoneNames []string
 | 
						|
	zoneMap   map[string]bool
 | 
						|
	zoneMu    sync.RWMutex
 | 
						|
}
 | 
						|
 | 
						|
// New returns a new instance of Metrics with the given address
 | 
						|
func New(addr string) *Metrics {
 | 
						|
	met := &Metrics{
 | 
						|
		Addr:    addr,
 | 
						|
		Reg:     prometheus.NewRegistry(),
 | 
						|
		zoneMap: make(map[string]bool),
 | 
						|
	}
 | 
						|
	// Add the default collectors
 | 
						|
	met.MustRegister(prometheus.NewGoCollector())
 | 
						|
	met.MustRegister(prometheus.NewProcessCollector(os.Getpid(), ""))
 | 
						|
 | 
						|
	// Add all of our collectors
 | 
						|
	met.MustRegister(buildInfo)
 | 
						|
	met.MustRegister(vars.RequestCount)
 | 
						|
	met.MustRegister(vars.RequestDuration)
 | 
						|
	met.MustRegister(vars.RequestSize)
 | 
						|
	met.MustRegister(vars.RequestDo)
 | 
						|
	met.MustRegister(vars.RequestType)
 | 
						|
	met.MustRegister(vars.ResponseSize)
 | 
						|
	met.MustRegister(vars.ResponseRcode)
 | 
						|
 | 
						|
	// Initialize metrics.
 | 
						|
	buildInfo.WithLabelValues(coremain.CoreVersion, coremain.GitCommit, runtime.Version()).Set(1)
 | 
						|
 | 
						|
	return met
 | 
						|
}
 | 
						|
 | 
						|
// MustRegister wraps m.Reg.MustRegister.
 | 
						|
func (m *Metrics) MustRegister(c prometheus.Collector) { m.Reg.MustRegister(c) }
 | 
						|
 | 
						|
// AddZone adds zone z to m.
 | 
						|
func (m *Metrics) AddZone(z string) {
 | 
						|
	m.zoneMu.Lock()
 | 
						|
	m.zoneMap[z] = true
 | 
						|
	m.zoneNames = keys(m.zoneMap)
 | 
						|
	m.zoneMu.Unlock()
 | 
						|
}
 | 
						|
 | 
						|
// RemoveZone remove zone z from m.
 | 
						|
func (m *Metrics) RemoveZone(z string) {
 | 
						|
	m.zoneMu.Lock()
 | 
						|
	delete(m.zoneMap, z)
 | 
						|
	m.zoneNames = keys(m.zoneMap)
 | 
						|
	m.zoneMu.Unlock()
 | 
						|
}
 | 
						|
 | 
						|
// ZoneNames returns the zones of m.
 | 
						|
func (m *Metrics) ZoneNames() []string {
 | 
						|
	m.zoneMu.RLock()
 | 
						|
	s := m.zoneNames
 | 
						|
	m.zoneMu.RUnlock()
 | 
						|
	return s
 | 
						|
}
 | 
						|
 | 
						|
// OnStartup sets up the metrics on startup.
 | 
						|
func (m *Metrics) OnStartup() error {
 | 
						|
	ln, err := net.Listen("tcp", m.Addr)
 | 
						|
	if err != nil {
 | 
						|
		log.Printf("[ERROR] Failed to start metrics handler: %s", err)
 | 
						|
		return err
 | 
						|
	}
 | 
						|
 | 
						|
	m.ln = ln
 | 
						|
	ListenAddr = m.ln.Addr().String()
 | 
						|
 | 
						|
	m.mux = http.NewServeMux()
 | 
						|
	m.mux.Handle("/metrics", promhttp.HandlerFor(m.Reg, promhttp.HandlerOpts{}))
 | 
						|
 | 
						|
	go func() {
 | 
						|
		http.Serve(m.ln, m.mux)
 | 
						|
	}()
 | 
						|
	return nil
 | 
						|
}
 | 
						|
 | 
						|
// OnShutdown tears down the metrics listener on shutdown and restart.
 | 
						|
func (m *Metrics) OnShutdown() error {
 | 
						|
	// We allow prometheus statements in multiple Server Blocks, but only the first
 | 
						|
	// will open the listener, for the rest they are all nil; guard against that.
 | 
						|
	if m.ln != nil {
 | 
						|
		return m.ln.Close()
 | 
						|
	}
 | 
						|
	return nil
 | 
						|
}
 | 
						|
 | 
						|
func keys(m map[string]bool) []string {
 | 
						|
	sx := []string{}
 | 
						|
	for k := range m {
 | 
						|
		sx = append(sx, k)
 | 
						|
	}
 | 
						|
	return sx
 | 
						|
}
 | 
						|
 | 
						|
// ListenAddr is assigned the address of the prometheus listener. Its use is mainly in tests where
 | 
						|
// we listen on "localhost:0" and need to retrieve the actual address.
 | 
						|
var ListenAddr string
 | 
						|
 | 
						|
var (
 | 
						|
	buildInfo = prometheus.NewGaugeVec(prometheus.GaugeOpts{
 | 
						|
		Namespace: plugin.Namespace,
 | 
						|
		Name:      "build_info",
 | 
						|
		Help:      "A metric with a constant '1' value labeled by version, revision, and goversion from which CoreDNS was built.",
 | 
						|
	}, []string{"version", "revision", "goversion"})
 | 
						|
)
 |