mirror of
https://github.com/coredns/coredns.git
synced 2025-10-29 01:04:15 -04:00
56bc7f399a
* plugin/transfer: only allow outgoing axfr over tcp Return refused when the query comes in over udp. No need to add a new test case as the current crop needed to be changed to use TCP. Fixes: #4450 Signed-off-by: Miek Gieben <miek@miek.nl> * transfer tests: this needs tcp as well Signed-off-by: Miek Gieben <miek@miek.nl>
59 lines
1.2 KiB
Go
59 lines
1.2 KiB
Go
package transfer
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"testing"
|
|
|
|
"github.com/coredns/coredns/plugin/pkg/dnstest"
|
|
"github.com/coredns/coredns/plugin/test"
|
|
|
|
"github.com/miekg/dns"
|
|
)
|
|
|
|
type (
|
|
t1 struct{}
|
|
t2 struct{}
|
|
)
|
|
|
|
func (t t1) Transfer(zone string, serial uint32) (<-chan []dns.RR, error) {
|
|
const z = "example.org."
|
|
if zone != z {
|
|
return nil, ErrNotAuthoritative
|
|
}
|
|
return nil, fmt.Errorf(z)
|
|
}
|
|
func (t t2) Transfer(zone string, serial uint32) (<-chan []dns.RR, error) {
|
|
const z = "sub.example.org."
|
|
if zone != z {
|
|
return nil, ErrNotAuthoritative
|
|
}
|
|
return nil, fmt.Errorf(z)
|
|
}
|
|
|
|
func TestZoneSelection(t *testing.T) {
|
|
tr := &Transfer{
|
|
Transferers: []Transferer{t1{}, t2{}},
|
|
xfrs: []*xfr{
|
|
{
|
|
Zones: []string{"example.org."},
|
|
to: []string{"192.0.2.1"}, // RFC 5737 IP, no interface should have this address.
|
|
},
|
|
{
|
|
Zones: []string{"sub.example.org."},
|
|
to: []string{"*"},
|
|
},
|
|
},
|
|
}
|
|
r := new(dns.Msg)
|
|
r.SetAxfr("sub.example.org.")
|
|
w := dnstest.NewRecorder(&test.ResponseWriter{TCP: true})
|
|
_, err := tr.ServeDNS(context.TODO(), w, r)
|
|
if err == nil {
|
|
t.Fatal("Expected error, got nil")
|
|
}
|
|
if x := err.Error(); x != "sub.example.org." {
|
|
t.Errorf("Expected transfer for zone %s, got %s", "sub.example.org", x)
|
|
}
|
|
}
|