mirror of
https://github.com/coredns/coredns.git
synced 2025-11-13 07:22:16 -05:00
ffebb46b38
This adds (somewhat hacky?) code to add a plugin label to the coredns_dns_responses_total metric. It's completely obvlious to the plugin as we just check who called the *recorder.WriteMsg method. We use runtime.Caller( 1 2 3) to get multiple levels of callers, this should be deep enough, but it depends on the dns.ResponseWriter wrapping that's occuring. README.md of metrics updates and test added in test/metrics_test.go to check for the label being set. I went through the plugin to see what metrics could be removed, but actually didn't find any, the plugin push out metrics that make sense. Due to the path fiddling to figure out the plugin name I doubt this works (out-of-the-box) for external plugins, but I haven't tested that. Signed-off-by: Miek Gieben <miek@miek.nl>
32 lines
844 B
Go
32 lines
844 B
Go
package metrics
|
|
|
|
import (
|
|
"runtime"
|
|
|
|
"github.com/coredns/coredns/plugin/pkg/dnstest"
|
|
"github.com/miekg/dns"
|
|
)
|
|
|
|
// Recorder is a dnstest.Recorder specific to the metrics plugin.
|
|
type Recorder struct {
|
|
*dnstest.Recorder
|
|
// CallerN holds the string return value of the call to runtime.Caller(N)
|
|
Caller1 string
|
|
Caller2 string
|
|
Caller3 string
|
|
}
|
|
|
|
// NewRecorder makes and returns a new Recorder.
|
|
func NewRecorder(w dns.ResponseWriter) *Recorder { return &Recorder{Recorder: dnstest.NewRecorder(w)} }
|
|
|
|
// WriteMsg records the status code and calls the
|
|
// underlying ResponseWriter's WriteMsg method.
|
|
func (r *Recorder) WriteMsg(res *dns.Msg) error {
|
|
_, r.Caller1, _, _ = runtime.Caller(1)
|
|
_, r.Caller2, _, _ = runtime.Caller(2)
|
|
_, r.Caller3, _, _ = runtime.Caller(3)
|
|
r.Len += res.Len()
|
|
r.Msg = res
|
|
return r.ResponseWriter.WriteMsg(res)
|
|
}
|