Improve Test Coverage (#511)

* add recipe scaling notes

* test theme rename

* fix coverage call to use poetry

* remove print

* remove async

* consolidate test case data

* fix mealplan tests

* remove redundant else

Co-authored-by: hay-kot <hay-kot@pm.me>
This commit is contained in:
Hayden
2021-06-13 13:09:44 -08:00
committed by GitHub
parent c325a49fc2
commit 2dc9c8e843
17 changed files with 249 additions and 230 deletions

View File

@@ -1,104 +1,102 @@
# import json
import json
# import pytest
# from fastapi.testclient import TestClient
# from tests.app_routes import AppRoutes
# from tests.utils.recipe_data import RecipeTestData
import pytest
from fastapi.testclient import TestClient
from tests.app_routes import AppRoutes
from tests.utils.recipe_data import RecipeSiteTestCase
# def get_meal_plan_template(first=None, second=None):
# return {
# "group": "Home",
# "startDate": "2021-01-18",
# "endDate": "2021-01-19",
# "meals": [
# {
# "slug": first,
# "date": "2021-1-17",
# },
# {
# "slug": second,
# "date": "2021-1-18",
# },
# ],
# }
def get_meal_plan_template(first=None, second=None):
return {
"group": "Home",
"startDate": "2021-01-18",
"endDate": "2021-01-19",
"planDays": [
{
"date": "2021-1-18",
"meals": [{"slug": first, "name": "", "description": ""}],
},
{
"date": "2021-1-19",
"meals": [{"slug": second, "name": "", "description": ""}],
},
],
}
# @pytest.fixture(scope="session")
# def slug_1(api_client: TestClient, api_routes: AppRoutes, token, recipe_store: list[RecipeTestData]):
# # Slug 1
# slug_1 = api_client.post(api_routes.recipes_create_url, json={"url": recipe_store[0].url}, headers=token)
# slug_1 = json.loads(slug_1.content)
@pytest.fixture(scope="session")
def slug_1(api_client: TestClient, api_routes: AppRoutes, token, recipe_store: list[RecipeSiteTestCase]):
slug_1 = api_client.post(api_routes.recipes_create_url, json={"url": recipe_store[0].url}, headers=token)
slug_1 = json.loads(slug_1.content)
# yield slug_1
yield slug_1
# api_client.delete(api_routes.recipes_recipe_slug(slug_1))
api_client.delete(api_routes.recipes_recipe_slug(slug_1))
# @pytest.fixture(scope="session")
# def slug_2(api_client: TestClient, api_routes: AppRoutes, token, recipe_store: list[RecipeTestData]):
# # Slug 2
# slug_2 = api_client.post(api_routes.recipes_create_url, json={"url": recipe_store[1].url}, headers=token)
# slug_2 = json.loads(slug_2.content)
@pytest.fixture(scope="session")
def slug_2(api_client: TestClient, api_routes: AppRoutes, token, recipe_store: list[RecipeSiteTestCase]):
slug_2 = api_client.post(api_routes.recipes_create_url, json={"url": recipe_store[1].url}, headers=token)
slug_2 = json.loads(slug_2.content)
# yield slug_2
yield slug_2
# api_client.delete(api_routes.recipes_recipe_slug(slug_2))
api_client.delete(api_routes.recipes_recipe_slug(slug_2))
# def test_create_mealplan(api_client: TestClient, api_routes: AppRoutes, slug_1, slug_2, token):
# meal_plan = get_meal_plan_template(slug_1, slug_2)
def test_create_mealplan(api_client: TestClient, api_routes: AppRoutes, slug_1, slug_2, token):
meal_plan = get_meal_plan_template(slug_1, slug_2)
# response = api_client.post(api_routes.meal_plans_create, json=meal_plan, headers=token)
# assert response.status_code == 201
response = api_client.post(api_routes.meal_plans_create, json=meal_plan, headers=token)
assert response.status_code == 201
# def test_read_mealplan(api_client: TestClient, api_routes: AppRoutes, slug_1, slug_2, token):
# response = api_client.get(api_routes.meal_plans_all, headers=token)
def test_read_mealplan(api_client: TestClient, api_routes: AppRoutes, slug_1, slug_2, token):
response = api_client.get(api_routes.meal_plans_all, headers=token)
# assert response.status_code == 200
assert response.status_code == 200
# meal_plan = get_meal_plan_template(slug_1, slug_2)
meal_plan_template = get_meal_plan_template(slug_1, slug_2)
# new_meal_plan = json.loads(response.text)
# meals = new_meal_plan[0]["meals"]
created_meal_plan = json.loads(response.text)
meals = created_meal_plan[0]["planDays"]
# assert meals[0]["slug"] == meal_plan["meals"][0]["slug"]
# assert meals[1]["slug"] == meal_plan["meals"][1]["slug"]
assert meals[0]["meals"][0]["slug"] == meal_plan_template["planDays"][0]["meals"][0]["slug"]
assert meals[1]["meals"][0]["slug"] == meal_plan_template["planDays"][1]["meals"][0]["slug"]
# def test_update_mealplan(api_client: TestClient, api_routes: AppRoutes, slug_1, slug_2, token):
def test_update_mealplan(api_client: TestClient, api_routes: AppRoutes, slug_1, slug_2, token):
# response = api_client.get(api_routes.meal_plans_all, headers=token)
response = api_client.get(api_routes.meal_plans_all, headers=token)
# existing_mealplan = json.loads(response.text)
# existing_mealplan = existing_mealplan[0]
existing_mealplan = json.loads(response.text)
existing_mealplan = existing_mealplan[0]
# # Swap
# plan_uid = existing_mealplan.get("uid")
# existing_mealplan["meals"][0]["slug"] = slug_2
# existing_mealplan["meals"][1]["slug"] = slug_1
# Swap
plan_uid = existing_mealplan.get("uid")
existing_mealplan["planDays"][0]["meals"][0]["slug"] = slug_2
existing_mealplan["planDays"][1]["meals"][0]["slug"] = slug_1
# response = api_client.put(api_routes.meal_plans_plan_id(plan_uid), json=existing_mealplan, headers=token)
response = api_client.put(api_routes.meal_plans_plan_id(plan_uid), json=existing_mealplan, headers=token)
# assert response.status_code == 200
assert response.status_code == 200
# response = api_client.get(api_routes.meal_plans_all, headers=token)
# existing_mealplan = json.loads(response.text)
# existing_mealplan = existing_mealplan[0]
response = api_client.get(api_routes.meal_plans_all, headers=token)
existing_mealplan = json.loads(response.text)
existing_mealplan = existing_mealplan[0]
# assert existing_mealplan["meals"][0]["slug"] == slug_2
# assert existing_mealplan["meals"][1]["slug"] == slug_1
assert existing_mealplan["planDays"][0]["meals"][0]["slug"] == slug_2
assert existing_mealplan["planDays"][1]["meals"][0]["slug"] == slug_1
# def test_delete_mealplan(api_client: TestClient, api_routes: AppRoutes, token):
# response = api_client.get(api_routes.meal_plans_all, headers=token)
def test_delete_mealplan(api_client: TestClient, api_routes: AppRoutes, token):
response = api_client.get(api_routes.meal_plans_all, headers=token)
# assert response.status_code == 200
# existing_mealplan = json.loads(response.text)
# existing_mealplan = existing_mealplan[0]
assert response.status_code == 200
existing_mealplan = json.loads(response.text)
existing_mealplan = existing_mealplan[0]
# plan_uid = existing_mealplan.get("uid")
# response = api_client.delete(api_routes.meal_plans_plan_id(plan_uid), headers=token)
plan_uid = existing_mealplan.get("uid")
response = api_client.delete(api_routes.meal_plans_plan_id(plan_uid), headers=token)
# assert response.status_code == 200
assert response.status_code == 200