Mirrors/mealie
1
0
Fork 0
mirror of https://github.com/mealie-recipes/mealie.git synced 2025-11-26 05:34:21 -05:00
Code Issues Packages Projects Releases Wiki Activity

fix: user-feedback-on-schema-mismatch (#1558)

Browse Source 
* validate schema version on restore

* show user error on backup failure
This commit is contained in:
Hayden
2022-08-14 11:06:35 -08:00
committed by GitHub
parent 7adcc86d03
commit 3985713cbd
4 changed files with 56 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
mealie/services/backups_v2/backup_v2.py
View File

@@ -9,6 +9,10 @@ from mealie.services.backups_v2.alchemy_exporter import AlchemyExporter
from mealie.services.backups_v2.backup_file import BackupFile
class BackupSchemaMismatch(Exception):
...
class BackupV2(BaseService):
def __init__(self, db_url: str = None) -> None:
super().__init__()
@@ -73,18 +77,28 @@ class BackupV2(BaseService):
self._postgres()
with backup as contents:
# ================================
# Validation
if not contents.validate():
self.logger.error(
"Invalid backup file. file does not contain required elements (data directory and database.json"
)
raise ValueError("Invalid backup file")
# Purge the Database
database_json = contents.read_tables()
if not AlchemyExporter.validate_schemas(database_json, self.db_exporter.dump()):
self.logger.error("Invalid backup file. Database schemas do not match")
raise BackupSchemaMismatch("Invalid backup file. Database schemas do not match")
# ================================
# Purge Database
self.logger.info("dropping all database tables")
self.db_exporter.drop_all()
database_json = contents.read_tables()
# ================================
# Restore Database
self.logger.info("importing database tables")
self.db_exporter.restore(database_json)