improve developer tooling (backend) (#1051)

* add basic pre-commit file

* add flake8

* add isort

* add pep585-upgrade (typing upgrades)

* use namespace for import

* add mypy

* update ci for backend

* flake8 scope

* fix version format

* update makefile

* disable strict option (temporary)

* fix mypy issues

* upgrade type hints (pre-commit)

* add vscode typing check

* add types to dev deps

* remote container draft

* update setup script

* update compose version

* run setup on create

* dev containers update

* remove unused pages

* update setup tips

* expose ports

* Update pre-commit to include flask8-print (#1053)

* Add in flake8-print to pre-commit

* pin version of flake8-print

* formatting

* update getting strated docs

* add mypy to pre-commit

* purge .mypy_cache on clean

* drop mypy

Co-authored-by: zackbcom <zackbcom@users.noreply.github.com>

mealie/routes/groups/controller_cookbooks.py

@@ -1,5 +1,4 @@
 from functools import cached_property
-from typing import Type
 
 from fastapi import APIRouter, HTTPException
 from pydantic import UUID4
@@ -24,7 +23,7 @@ class GroupCookbookController(BaseUserController):
     def repo(self):
         return self.deps.repos.cookbooks.by_group(self.group_id)
 
-    def registered_exceptions(self, ex: Type[Exception]) -> str:
+    def registered_exceptions(self, ex: type[Exception]) -> str:
         registered = {
             **mealie_registered_exceptions(self.deps.t),
         }

mealie/routes/groups/controller_group_reports.py

@@ -1,5 +1,4 @@
 from functools import cached_property
-from typing import Type
 
 from fastapi import APIRouter
 from pydantic import UUID4
@@ -19,7 +18,7 @@ class GroupReportsController(BaseUserController):
     def repo(self):
         return self.deps.repos.group_reports.by_group(self.deps.acting_user.group_id)
 
-    def registered_exceptions(self, ex: Type[Exception]) -> str:
+    def registered_exceptions(self, ex: type[Exception]) -> str:
         return {
             **mealie_registered_exceptions(self.deps.t),
         }.get(ex, "An unexpected error occurred.")

mealie/routes/groups/controller_mealplan.py

@@ -1,6 +1,5 @@
 from datetime import date, timedelta
 from functools import cached_property
-from typing import Type
 
 from fastapi import APIRouter, HTTPException
 
@@ -24,7 +23,7 @@ class GroupMealplanController(BaseUserController):
     def repo(self) -> RepositoryMeals:
         return self.repos.meals.by_group(self.group_id)
 
-    def registered_exceptions(self, ex: Type[Exception]) -> str:
+    def registered_exceptions(self, ex: type[Exception]) -> str:
         registered = {
             **mealie_registered_exceptions(self.deps.t),
         }
@@ -58,7 +57,7 @@ class GroupMealplanController(BaseUserController):
         )
 
         recipe_repo = self.repos.recipes.by_group(self.group_id)
-        random_recipes: Recipe = []
+        random_recipes: list[Recipe] = []
 
         if not rules:  # If no rules are set, return any random recipe from the group
             random_recipes = recipe_repo.get_random()

mealie/routes/groups/controller_migrations.py

@@ -1,4 +1,5 @@
 import shutil
+from pathlib import Path
 
 from fastapi import Depends, File, Form
 from fastapi.datastructures import UploadFile
@@ -8,7 +9,13 @@ from mealie.routes._base import BaseUserController, controller
 from mealie.routes._base.routers import UserAPIRouter
 from mealie.schema.group.group_migration import SupportedMigrations
 from mealie.schema.reports.reports import ReportSummary
-from mealie.services.migrations import ChowdownMigrator, MealieAlphaMigrator, NextcloudMigrator, PaprikaMigrator
+from mealie.services.migrations import (
+    BaseMigrator,
+    ChowdownMigrator,
+    MealieAlphaMigrator,
+    NextcloudMigrator,
+    PaprikaMigrator,
+)
 
 router = UserAPIRouter(prefix="/groups/migrations", tags=["Group: Migrations"])
 
@@ -21,7 +28,7 @@ class GroupMigrationController(BaseUserController):
         add_migration_tag: bool = Form(False),
         migration_type: SupportedMigrations = Form(...),
         archive: UploadFile = File(...),
-        temp_path: str = Depends(temporary_zip_path),
+        temp_path: Path = Depends(temporary_zip_path),
     ):
         # Save archive to temp_path
         with temp_path.open("wb") as buffer:
@@ -36,6 +43,8 @@ class GroupMigrationController(BaseUserController):
             "add_migration_tag": add_migration_tag,
         }
 
+        migrator: BaseMigrator
+
         match migration_type:
             case SupportedMigrations.chowdown:
                 migrator = ChowdownMigrator(**args)