feat(backend): ✨ migrate site-settings to groups (#673)

* feat(frontend): ✨ add user registration page (WIP)

* feat(backend): ✨ add user registration (WIP)

* test(backend): ✅ add validator testing for registration schema

* feat(backend): ✨ continued work on user sign-up

* feat(backend): ✨ add signup flow and user/group settings

* test(backend): ✅ user-creation tests and small refactor of existing tests

* fix(backend): ✅ fix failing group tests

* style: 🎨 fix lint issues

Co-authored-by: hay-kot <hay-kot@pm.me>

mealie/services/cookbook/__init__.py

@@ -1 +0,0 @@
-from .cookbook_service import *

mealie/services/group_services/__init__.py

@@ -1,2 +1,3 @@
+from .cookbook_service import *
 from .group_service import *
 from .webhook_service import *

mealie/services/group_services/cookbook_service.py

@@ -3,7 +3,7 @@ from __future__ import annotations
 from mealie.core.root_logger import get_logger
 from mealie.db.database import get_database
 from mealie.schema.cookbook.cookbook import CreateCookBook, ReadCookBook, RecipeCookBook, SaveCookBook, UpdateCookBook
-from mealie.services.base_http_service.http_services import UserHttpService
+from mealie.services._base_http_service.http_services import UserHttpService
 from mealie.services.events import create_group_event
 from mealie.utils.error_messages import ErrorMessages
 

mealie/services/group_services/group_mixins.py

@@ -0,0 +1,16 @@
+from mealie.db.database import get_database
+from mealie.schema.group.group_preferences import CreateGroupPreferences
+from mealie.schema.user.user import GroupBase, GroupInDB
+
+
+def create_new_group(session, g_base: GroupBase, g_preferences: CreateGroupPreferences = None) -> GroupInDB:
+    db = get_database()
+    created_group = db.groups.create(session, g_base)
+
+    g_preferences = g_preferences or CreateGroupPreferences(group_id=0)
+
+    g_preferences.group_id = created_group.id
+
+    db.group_preferences.create(session, g_preferences)
+
+    return created_group

mealie/services/group_services/group_service.py

@@ -4,9 +4,10 @@ from fastapi import Depends, HTTPException, status
 
 from mealie.core.dependencies.grouped import UserDeps
 from mealie.core.root_logger import get_logger
+from mealie.schema.group.group_preferences import UpdateGroupPreferences
 from mealie.schema.recipe.recipe_category import CategoryBase
 from mealie.schema.user.user import GroupInDB
-from mealie.services.base_http_service.http_services import UserHttpService
+from mealie.services._base_http_service.http_services import UserHttpService
 from mealie.services.events import create_group_event
 
 logger = get_logger(module=__name__)
@@ -41,8 +42,11 @@ class GroupSelfService(UserHttpService[int, str]):
         return self.item
 
     def update_categories(self, new_categories: list[CategoryBase]):
-        if not self.item:
-            return
         self.item.categories = new_categories
 
         return self.db.groups.update(self.session, self.group_id, self.item)
+
+    def update_preferences(self, new_preferences: UpdateGroupPreferences):
+        self.db.group_preferences.update(self.session, self.group_id, new_preferences)
+
+        return self.populate_item()

mealie/services/group_services/webhook_service.py

@@ -5,7 +5,7 @@ from fastapi import HTTPException, status
 from mealie.core.root_logger import get_logger
 from mealie.schema.group import ReadWebhook
 from mealie.schema.group.webhook import CreateWebhook, SaveWebhook
-from mealie.services.base_http_service.http_services import UserHttpService
+from mealie.services._base_http_service.http_services import UserHttpService
 from mealie.services.events import create_group_event
 
 logger = get_logger(module=__name__)

mealie/services/recipe/recipe_service.py

@@ -8,7 +8,7 @@ from sqlalchemy.exc import IntegrityError
 from mealie.core.dependencies.grouped import PublicDeps, UserDeps
 from mealie.core.root_logger import get_logger
 from mealie.schema.recipe.recipe import CreateRecipe, Recipe
-from mealie.services.base_http_service.http_services import PublicHttpService
+from mealie.services._base_http_service.http_services import PublicHttpService
 from mealie.services.events import create_recipe_event
 
 logger = get_logger(module=__name__)

mealie/services/scraper/ingredient_nlp/processor.py

@@ -55,7 +55,6 @@ def _exec_crf_test(input_text):
 
 
 def convert_list_to_crf_model(list_of_ingrdeint_text: list[str]):
-    print(list_of_ingrdeint_text)
     crf_output = _exec_crf_test([pre_process_string(x) for x in list_of_ingrdeint_text])
     crf_models = [CRFIngredient(**ingredient) for ingredient in utils.import_data(crf_output.split("\n"))]
 
@@ -82,6 +81,3 @@ def convert_crf_models_to_ingredients(crf_models: list[CRFIngredient]):
 if __name__ == "__main__":
     crf_models = convert_list_to_crf_model(INGREDIENT_TEXT)
     ingredients = convert_crf_models_to_ingredients(crf_models)
-
-    for ingredient in ingredients:
-        print(ingredient.input)

mealie/services/user_services/__init__.py

@@ -0,0 +1 @@
+from .user_service import *

mealie/services/user_services/registration_service.py

@@ -0,0 +1,61 @@
+from mealie.core.root_logger import get_logger
+from mealie.core.security import hash_password
+from mealie.schema.group.group_preferences import CreateGroupPreferences
+from mealie.schema.user.registration import CreateUserRegistration
+from mealie.schema.user.user import GroupBase, GroupInDB, PrivateUser, UserIn
+from mealie.services._base_http_service.http_services import PublicHttpService
+from mealie.services.events import create_user_event
+from mealie.services.group_services.group_mixins import create_new_group
+
+logger = get_logger(module=__name__)
+
+
+class RegistrationService(PublicHttpService[int, str]):
+    event_func = create_user_event
+
+    def populate_item() -> None:
+        pass
+
+    def register_user(self, registration: CreateUserRegistration) -> PrivateUser:
+        self.registration = registration
+
+        logger.info(f"Registering user {registration.username}")
+
+        if registration.group:
+            group = self._create_new_group()
+        else:
+            group = self._existing_group_ref()
+
+        return self._create_new_user(group)
+
+    def _create_new_user(self, group: GroupInDB) -> PrivateUser:
+        new_user = UserIn(
+            email=self.registration.email,
+            username=self.registration.username,
+            password=hash_password(self.registration.password),
+            full_name=self.registration.username,
+            advanced=self.registration.advanced,
+            group=group.name,
+        )
+
+        return self.db.users.create(self.session, new_user)
+
+    def _create_new_group(self) -> GroupInDB:
+        group_data = GroupBase(name=self.registration.group)
+
+        group_preferences = CreateGroupPreferences(
+            group_id=0,
+            private_group=self.registration.private,
+            first_day_of_week=0,
+            recipe_public=not self.registration.private,
+            recipe_show_nutrition=self.registration.advanced,
+            recipe_show_assets=self.registration.advanced,
+            recipe_landscape_view=False,
+            recipe_disable_comments=self.registration.advanced,
+            recipe_disable_amount=self.registration.advanced,
+        )
+
+        return create_new_group(self.session, group_data, group_preferences)
+
+    def _existing_group_ref(self) -> GroupInDB:
+        pass

mealie/services/user_services/user_service.py

@@ -3,7 +3,7 @@ from fastapi import HTTPException, status
 from mealie.core.root_logger import get_logger
 from mealie.core.security import hash_password, verify_password
 from mealie.schema.user.user import ChangePassword, PrivateUser
-from mealie.services.base_http_service.http_services import UserHttpService
+from mealie.services._base_http_service.http_services import UserHttpService
 from mealie.services.events import create_user_event
 
 logger = get_logger(module=__name__)