mirror of
https://github.com/mealie-recipes/mealie.git
synced 2025-12-04 17:35:21 -05:00
feat: add unit abbreviation support (#1332)
* add 'use-abbreviation' db column * type generation * add view and edit elements * check for use_abbreviation to display * fix: alembic version check * test: add use_abbreviation prop tests
This commit is contained in:
@@ -9,17 +9,19 @@ from tests.utils.fixture_schemas import TestUser
|
||||
class Routes:
|
||||
base = "/api/units"
|
||||
|
||||
@staticmethod
|
||||
def item(item_id: int) -> str:
|
||||
return f"{Routes.base}/{item_id}"
|
||||
|
||||
|
||||
@pytest.fixture(scope="function")
|
||||
def unit(api_client: TestClient, unique_user: TestUser) -> dict:
|
||||
def unit(api_client: TestClient, unique_user: TestUser):
|
||||
data = CreateIngredientUnit(
|
||||
name=random_string(10),
|
||||
description=random_string(10),
|
||||
fraction=random_bool(),
|
||||
abbreviation=random_string(3) + ".",
|
||||
abbreviation=f"{random_string(3)}.",
|
||||
use_abbreviation=random_bool(),
|
||||
).dict(by_alias=True)
|
||||
|
||||
response = api_client.post(Routes.base, json=data, headers=unique_user.token)
|
||||
@@ -52,6 +54,7 @@ def test_read_unit(api_client: TestClient, unit: dict, unique_user: TestUser):
|
||||
assert as_json["description"] == unit["description"]
|
||||
assert as_json["fraction"] == unit["fraction"]
|
||||
assert as_json["abbreviation"] == unit["abbreviation"]
|
||||
assert as_json["useAbbreviation"] == unit["useAbbreviation"]
|
||||
|
||||
|
||||
def test_update_unit(api_client: TestClient, unit: dict, unique_user: TestUser):
|
||||
@@ -60,8 +63,10 @@ def test_update_unit(api_client: TestClient, unit: dict, unique_user: TestUser):
|
||||
"name": random_string(10),
|
||||
"description": random_string(10),
|
||||
"fraction": not unit["fraction"],
|
||||
"abbreviation": random_string(3) + ".",
|
||||
"abbreviation": f"{random_string(3)}.",
|
||||
"useAbbreviation": not unit["useAbbreviation"],
|
||||
}
|
||||
|
||||
response = api_client.put(Routes.item(unit["id"]), json=update_data, headers=unique_user.token)
|
||||
assert response.status_code == 200
|
||||
as_json = response.json()
|
||||
@@ -71,14 +76,15 @@ def test_update_unit(api_client: TestClient, unit: dict, unique_user: TestUser):
|
||||
assert as_json["description"] == update_data["description"]
|
||||
assert as_json["fraction"] == update_data["fraction"]
|
||||
assert as_json["abbreviation"] == update_data["abbreviation"]
|
||||
assert as_json["useAbbreviation"] == update_data["useAbbreviation"]
|
||||
|
||||
|
||||
def test_delete_unit(api_client: TestClient, unit: dict, unique_user: TestUser):
|
||||
id = unit["id"]
|
||||
item_id = unit["id"]
|
||||
|
||||
response = api_client.delete(Routes.item(id), headers=unique_user.token)
|
||||
response = api_client.delete(Routes.item(item_id), headers=unique_user.token)
|
||||
|
||||
assert response.status_code == 200
|
||||
|
||||
response = api_client.get(Routes.item(id), headers=unique_user.token)
|
||||
response = api_client.get(Routes.item(item_id), headers=unique_user.token)
|
||||
assert response.status_code == 404
|
||||
|
||||
Reference in New Issue
Block a user