Mirrors/mealie
1
0
Fork 0
mirror of https://github.com/mealie-recipes/mealie.git synced 2025-10-31 10:13:32 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix: Preserve "Completed On" Date In Checked Shopping List Items (#5665)

Browse Source
This commit is contained in:
Michael Genson
2025-07-10 11:41:34 -05:00
committed by GitHub
parent 5cf3e2565a
commit 63a4d4c801
1 changed files with 17 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

31
frontend/pages/shopping-lists/[id].vue
View File

@@ -707,7 +707,7 @@ export default defineNuxtComponent({
} }
}); });
if (hasChanged) { if (hasChanged) {
updateListItems(); updateUncheckedListItems();
} }
} }
@@ -727,7 +727,9 @@ export default defineNuxtComponent({
} }
}); });
if (hasChanged) { if (hasChanged) {
updateListItems(); listItems.unchecked = [...listItems.unchecked, ...listItems.checked];
listItems.checked = [];
updateUncheckedListItems();
} }
} }
@@ -1051,8 +1053,13 @@ export default defineNuxtComponent({
.sort(sortCheckedItems); .sort(sortCheckedItems);
} }
// Update the item if it's checked, otherwise updateUncheckedListItems will handle it
if (item.checked) {
shoppingListItemActions.updateItem(item);
}
updateListItemOrder(); updateListItemOrder();
updateListItems(); updateUncheckedListItems();
} }
function deleteListItem(item: ShoppingListItemOut) { function deleteListItem(item: ShoppingListItemOut) {
@@ -1144,7 +1151,7 @@ export default defineNuxtComponent({
// since the user has manually reordered the list, we should preserve this order // since the user has manually reordered the list, we should preserve this order
preserveItemOrder.value = true; preserveItemOrder.value = true;
updateListItems(); updateUncheckedListItems();
} }
function updateIndexUncheckedByLabel(labelName: string, labeledUncheckedItems: ShoppingListItemOut[]) { function updateIndexUncheckedByLabel(labelName: string, labeledUncheckedItems: ShoppingListItemOut[]) {
@@ -1167,7 +1174,7 @@ export default defineNuxtComponent({
// save changes // save changes
listItems.unchecked = allUncheckedItems; listItems.unchecked = allUncheckedItems;
listItems.checked = shoppingList.value?.listItems?.filter(item => item.checked) || []; listItems.checked = shoppingList.value?.listItems?.filter(item => item.checked) || [];
updateListItems(); updateUncheckedListItems();
} }
function deleteListItems(items: ShoppingListItemOut[]) { function deleteListItems(items: ShoppingListItemOut[]) {
@@ -1187,27 +1194,23 @@ export default defineNuxtComponent({
refresh(); refresh();
} }
function updateListItems() { function updateUncheckedListItems() {
if (!shoppingList.value?.listItems) { if (!shoppingList.value?.listItems) {
return; return;
} }
// Set Position // Set position for unchecked items
shoppingList.value.listItems = listItems.unchecked.concat(listItems.checked).map((itm: ShoppingListItemOut, idx: number) => { listItems.unchecked.forEach((item: ShoppingListItemOut, idx: number) => {
itm.position = idx; item.position = idx;
return itm;
});
shoppingList.value.listItems.forEach((item) => {
shoppingListItemActions.updateItem(item); shoppingListItemActions.updateItem(item);
}); });
refresh(); refresh();
} }
return { return {
...toRefs(state), ...toRefs(state),
addRecipeReferenceToList, addRecipeReferenceToList,
updateListItems,
allLabels, allLabels,
contextMenu, contextMenu,
contextMenuAction, contextMenuAction,