Mirrors/mealie
1
0
Fork 0
mirror of https://github.com/mealie-recipes/mealie.git synced 2025-10-26 15:54:20 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix: Handle missing OIDC groups claim (#6054)

Browse Source
This commit is contained in:
Xavier L.
2025-08-29 17:07:00 -04:00
committed by GitHub
parent cc2e33a254
commit 6d2936cab6
3 changed files with 56 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

43
tests/unit_tests/core/security/providers/test_openid_provider.py
View File

@@ -61,6 +61,49 @@ def test_missing_groups_claim(monkeypatch: MonkeyPatch):
auth_provider.authenticate()
def test_missing_groups_claim_admin(monkeypatch: MonkeyPatch):
monkeypatch.setenv("OIDC_ADMIN_GROUP", "mealie_admin")
get_app_settings.cache_clear()
data = {
"preferred_username": "dude1",
"email": "email@email.com",
"name": "Firstname Lastname",
}
auth_provider = OpenIDProvider(None, data)
with pytest.raises(MissingClaimException):
auth_provider.authenticate()
def test_missing_groups_claim_with_default(monkeypatch: MonkeyPatch):
monkeypatch.setenv("OIDC_USER_GROUP", "mealie_user")
get_app_settings.cache_clear()
data = {
"preferred_username": "dude1",
"email": "email@email.com",
"name": "Firstname Lastname",
}
auth_provider = OpenIDProvider(None, data, True)
assert auth_provider.authenticate() is None
def test_missing_groups_claim_admin_group_with_default(monkeypatch: MonkeyPatch, unique_user: TestUser):
monkeypatch.setenv("OIDC_ADMIN_GROUP", "mealie_admin")
get_app_settings.cache_clear()
data = {
"preferred_username": "dude1",
"email": unique_user.email,
"name": "Firstname Lastname",
}
auth_provider = OpenIDProvider(unique_user.repos.session, data, True)
assert auth_provider.authenticate() is not None
def test_missing_user_group(monkeypatch: MonkeyPatch):
monkeypatch.setenv("OIDC_USER_GROUP", "mealie_user")
get_app_settings.cache_clear()