Mirrors/mealie
1
0
Fork 0
mirror of https://github.com/mealie-recipes/mealie.git synced 2026-07-17 21:20:15 -04:00
Code Issues Packages Projects Releases Wiki Activity

fix: truncate scraped recipe slug to filesystem-safe length (#7862)

Browse Source 
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
TowyTowy
2026-07-17 20:37:19 +02:00
committed by GitHub
parent 31187b1a74
commit 95277e0e6b
2 changed files with 43 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

40
tests/unit_tests/services_tests/scraper_tests/test_scraper.py Normal file
View File

@@ -0,0 +1,40 @@
import pytest
from mealie.lang.providers import get_locale_provider
from mealie.schema.recipe.recipe import Recipe
from mealie.services.scraper import scraper
from mealie.services.scraper.recipe_scraper import RecipeScraper
from mealie.services.scraper.scraped_extras import ScrapedExtras
@pytest.mark.asyncio
async def test_create_from_html_truncates_long_slug(monkeypatch):
"""A recipe scraped with an excessively long name must yield a slug short enough
to be used as a filesystem directory name.
Regression test for GH #7662: scraping (e.g. an Instagram caption) dumped the entire
text into the recipe name. The scraper used a raw ``slugify`` instead of the shared
``create_recipe_slug`` helper, so the persisted slug could exceed the OS 255-byte
filename limit. Editing/saving the recipe then raised an uncaught
``OSError: [Errno 36] File name too long`` in ``RecipeService.check_assets``.
"""
# ~1300 characters, mirroring the caption-as-title data from the bug report
long_name = "High Protein Low Calorie Recipes Smash Or Pass " * 28
async def fake_scrape(self, url, html=None, on_progress=None):
return Recipe(name=long_name), ScrapedExtras()
monkeypatch.setattr(RecipeScraper, "scrape", fake_scrape)
translator = get_locale_provider()
recipe, _ = await scraper.create_from_html(
"https://example.com/recipe",
repos=None, # type: ignore[arg-type]
translator=translator,
html="<html></html>",
)
# The full title is preserved (name column is unbounded)...
assert recipe.name == long_name
# ...but the slug is truncated to a filesystem-safe length.
assert 0 < len(recipe.slug) <= 250