Mirrors/mealie
1
0
Fork 0
mirror of https://github.com/mealie-recipes/mealie.git synced 2025-12-29 13:27:09 -05:00
Code Issues Packages Projects Releases Wiki Activity

fix: group creation (#1126)

Browse Source 
* fix: unify group creation - closes #1100

* tests: disable password hashing during testing

* tests: fix email config tests
This commit is contained in:
Hayden
2022-04-02 19:33:15 -08:00
committed by GitHub
parent e9bb39c744
commit c988de1921
11 changed files with 113 additions and 33 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
mealie/routes/admin/admin_management_groups.py
View File

@@ -8,6 +8,7 @@ from mealie.schema.mapper import mapper
from mealie.schema.query import GetAll
from mealie.schema.response.responses import ErrorResponse
from mealie.schema.user.user import GroupBase, GroupInDB
from mealie.services.group_services.group_service import GroupService
from .._base import BaseAdminController, controller
from .._base.dependencies import SharedDependencies
@@ -44,7 +45,7 @@ class AdminUserManagementRoutes(BaseAdminController):
@router.post("", response_model=GroupInDB, status_code=status.HTTP_201_CREATED)
def create_one(self, data: GroupBase):
return self.mixins.create_one(data)
return GroupService.create_group(self.deps.repos, data)
@router.get("/{item_id}", response_model=GroupInDB)
def get_one(self, item_id: UUID4):
@@ -69,7 +70,7 @@ class AdminUserManagementRoutes(BaseAdminController):
def delete_one(self, item_id: UUID4):
item = self.repo.get_one(item_id)
if len(item.users) > 0:
if item and len(item.users) > 0:
raise HTTPException(
status_code=status.HTTP_400_BAD_REQUEST,
detail=ErrorResponse.respond(message="Cannot delete group with users"),