lint: enable nakedret (#7569)

Replace naked returns with explicit return values to satisfy nakedret
linter and improve readability.

Signed-off-by: Ville Vesilehto <ville@vesilehto.fi>

.golangci.yml

@@ -13,6 +13,7 @@ linters:
     - govet
     - ineffassign
     - intrange
+    - nakedret
     - nolintlint
     - prealloc
     - protogetter

plugin/file/tree/tree.go

@@ -213,7 +213,7 @@ func (n *Node) insert(rr dns.RR) (root *Node, d int) {
 
 	root = n
 
-	return
+	return root, d
 }
 
 // DeleteMin deletes the node with the minimum value in the tree.

plugin/loadbalance/loadbalance_test.go

@@ -192,7 +192,7 @@ func countRecords(result []dns.RR) (cname int, address int, mx int, sorted bool)
 			state = Any
 		}
 	}
-	return
+	return cname, address, mx, sorted
 }
 
 func handler() plugin.Handler {

plugin/rewrite/name.go

@@ -417,7 +417,7 @@ func parseAnswerRules(name string, args []string) (auto bool, rules ResponseRule
 	if auto && nameRules > 0 {
 		return false, nil, fmt.Errorf("auto name answer rule cannot be combined with explicit name anwer rules")
 	}
-	return
+	return auto, rules, nil
 }
 
 // hasClosingDot returns true if s has a closing dot at the end.

plugin/template/setup.go

@@ -158,5 +158,5 @@ func templateParse(c *caddy.Controller) (handler Handler, err error) {
 		handler.Templates = append(handler.Templates, t)
 	}
 
-	return
+	return handler, nil
 }