plugin/health: remove ability to poll other plugins (#2547)

* plugin/health: remove ability to poll other plugins

This mechanism defeats the purpose any plugin (mostly) caching can still
be alive, we can probably forward queries still. Don't poll plugins,
just tell the world we're up and running.

It was only actually used in kubernetes; and there specifically would
mean any network hiccup would NACK the entire server health.

Fixes: #2534

Signed-off-by: Miek Gieben <miek@miek.nl>

* update docs based on feedback

Signed-off-by: Miek Gieben <miek@miek.nl>

plugin/health/setup.go

@@ -5,7 +5,6 @@ import (
 	"net"
 	"time"
 
-	"github.com/coredns/coredns/core/dnsserver"
 	"github.com/coredns/coredns/plugin"
 	"github.com/coredns/coredns/plugin/metrics"
 
@@ -28,32 +27,6 @@ func setup(c *caddy.Controller) error {
 	h := newHealth(addr)
 	h.lameduck = lame
 
-	c.OnStartup(func() error {
-		plugins := dnsserver.GetConfig(c).Handlers()
-		for _, p := range plugins {
-			if x, ok := p.(Healther); ok {
-				h.h = append(h.h, x)
-			}
-		}
-		return nil
-	})
-
-	c.OnStartup(func() error {
-		// Poll all middleware every second.
-		h.poll()
-		go func() {
-			for {
-				select {
-				case <-time.After(1 * time.Second):
-					h.poll()
-				case <-h.pollstop:
-					return
-				}
-			}
-		}()
-		return nil
-	})
-
 	c.OnStartup(func() error {
 		metrics.MustRegister(c, HealthDuration)
 		return nil