mirror of
				https://github.com/coredns/coredns.git
				synced 2025-10-31 10:13:14 -04:00 
			
		
		
		
	* request.Match check Response bit as well We should check this bit and reject them as invalid. * Fix test
		
			
				
	
	
		
			205 lines
		
	
	
		
			5.0 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			205 lines
		
	
	
		
			5.0 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
| package request
 | |
| 
 | |
| import (
 | |
| 	"fmt"
 | |
| 	"testing"
 | |
| 
 | |
| 	"github.com/coredns/coredns/plugin/test"
 | |
| 
 | |
| 	"github.com/miekg/dns"
 | |
| )
 | |
| 
 | |
| func TestRequestDo(t *testing.T) {
 | |
| 	st := testRequest()
 | |
| 
 | |
| 	st.Do()
 | |
| 	if st.do == nil {
 | |
| 		t.Fatalf("Expected st.do to be set")
 | |
| 	}
 | |
| }
 | |
| 
 | |
| func TestRequestRemote(t *testing.T) {
 | |
| 	st := testRequest()
 | |
| 	if st.IP() != "10.240.0.1" {
 | |
| 		t.Fatalf("Wrong IP from request")
 | |
| 	}
 | |
| 	p := st.Port()
 | |
| 	if p == "" {
 | |
| 		t.Fatalf("Failed to get Port from request")
 | |
| 	}
 | |
| 	if p != "40212" {
 | |
| 		t.Fatalf("Wrong port from request")
 | |
| 	}
 | |
| }
 | |
| 
 | |
| func TestRequestMalformed(t *testing.T) {
 | |
| 	m := new(dns.Msg)
 | |
| 	st := Request{Req: m}
 | |
| 
 | |
| 	if x := st.QType(); x != 0 {
 | |
| 		t.Errorf("Expected 0 Qtype, got %d", x)
 | |
| 	}
 | |
| 
 | |
| 	if x := st.QClass(); x != 0 {
 | |
| 		t.Errorf("Expected 0 QClass, got %d", x)
 | |
| 	}
 | |
| 
 | |
| 	if x := st.QName(); x != "." {
 | |
| 		t.Errorf("Expected . Qname, got %s", x)
 | |
| 	}
 | |
| 
 | |
| 	if x := st.Name(); x != "." {
 | |
| 		t.Errorf("Expected . Name, got %s", x)
 | |
| 	}
 | |
| 
 | |
| 	if x := st.Type(); x != "" {
 | |
| 		t.Errorf("Expected empty Type, got %s", x)
 | |
| 	}
 | |
| 
 | |
| 	if x := st.Class(); x != "" {
 | |
| 		t.Errorf("Expected empty Class, got %s", x)
 | |
| 	}
 | |
| }
 | |
| 
 | |
| func TestRequestScrubAnswer(t *testing.T) {
 | |
| 	m := new(dns.Msg)
 | |
| 	m.SetQuestion("large.example.com.", dns.TypeSRV)
 | |
| 	req := Request{W: &test.ResponseWriter{}, Req: m}
 | |
| 
 | |
| 	reply := new(dns.Msg)
 | |
| 	reply.SetReply(m)
 | |
| 	for i := 1; i < 200; i++ {
 | |
| 		reply.Answer = append(reply.Answer, test.SRV(
 | |
| 			fmt.Sprintf("large.example.com. 10 IN SRV 0 0 80 10-0-0-%d.default.pod.k8s.example.com.", i)))
 | |
| 	}
 | |
| 
 | |
| 	_, got := req.Scrub(reply)
 | |
| 	if want := ScrubAnswer; want != got {
 | |
| 		t.Errorf("want scrub result %d, got %d", want, got)
 | |
| 	}
 | |
| 	if want, got := req.Size(), reply.Len(); want < got {
 | |
| 		t.Errorf("want scrub to reduce message length below %d bytes, got %d bytes", want, got)
 | |
| 	}
 | |
| 	if !reply.Truncated {
 | |
| 		t.Errorf("want scrub to set truncated bit")
 | |
| 	}
 | |
| }
 | |
| 
 | |
| func TestRequestScrubExtra(t *testing.T) {
 | |
| 	m := new(dns.Msg)
 | |
| 	m.SetQuestion("large.example.com.", dns.TypeSRV)
 | |
| 	req := Request{W: &test.ResponseWriter{}, Req: m}
 | |
| 
 | |
| 	reply := new(dns.Msg)
 | |
| 	reply.SetReply(m)
 | |
| 	for i := 1; i < 200; i++ {
 | |
| 		reply.Extra = append(reply.Extra, test.SRV(
 | |
| 			fmt.Sprintf("large.example.com. 10 IN SRV 0 0 80 10-0-0-%d.default.pod.k8s.example.com.", i)))
 | |
| 	}
 | |
| 
 | |
| 	_, got := req.Scrub(reply)
 | |
| 	if want := ScrubExtra; want != got {
 | |
| 		t.Errorf("want scrub result %d, got %d", want, got)
 | |
| 	}
 | |
| 	if want, got := req.Size(), reply.Len(); want < got {
 | |
| 		t.Errorf("want scrub to reduce message length below %d bytes, got %d bytes", want, got)
 | |
| 	}
 | |
| 	if reply.Truncated {
 | |
| 		t.Errorf("want scrub to not set truncated bit")
 | |
| 	}
 | |
| }
 | |
| 
 | |
| func TestRequestScrubExtraEdns0(t *testing.T) {
 | |
| 	m := new(dns.Msg)
 | |
| 	m.SetQuestion("large.example.com.", dns.TypeSRV)
 | |
| 	m.SetEdns0(4096, true)
 | |
| 	req := Request{W: &test.ResponseWriter{}, Req: m}
 | |
| 
 | |
| 	reply := new(dns.Msg)
 | |
| 	reply.SetReply(m)
 | |
| 	for i := 1; i < 200; i++ {
 | |
| 		reply.Extra = append(reply.Extra, test.SRV(
 | |
| 			fmt.Sprintf("large.example.com. 10 IN SRV 0 0 80 10-0-0-%d.default.pod.k8s.example.com.", i)))
 | |
| 	}
 | |
| 
 | |
| 	_, got := req.Scrub(reply)
 | |
| 	if want := ScrubExtra; want != got {
 | |
| 		t.Errorf("want scrub result %d, got %d", want, got)
 | |
| 	}
 | |
| 	if want, got := req.Size(), reply.Len(); want < got {
 | |
| 		t.Errorf("want scrub to reduce message length below %d bytes, got %d bytes", want, got)
 | |
| 	}
 | |
| 	if reply.Truncated {
 | |
| 		t.Errorf("want scrub to not set truncated bit")
 | |
| 	}
 | |
| 	opt := reply.Extra[len(reply.Extra)-1]
 | |
| 	if opt.Header().Rrtype != dns.TypeOPT {
 | |
| 		t.Errorf("Last RR must be OPT record")
 | |
| 	}
 | |
| }
 | |
| 
 | |
| func TestRequestScrubAnswerExact(t *testing.T) {
 | |
| 	m := new(dns.Msg)
 | |
| 	m.SetQuestion("large.example.com.", dns.TypeSRV)
 | |
| 	m.SetEdns0(867, false) // Bit fiddly, but this hits the rl == size break clause in Scrub, 52 RRs should remain.
 | |
| 	req := Request{W: &test.ResponseWriter{}, Req: m}
 | |
| 
 | |
| 	reply := new(dns.Msg)
 | |
| 	reply.SetReply(m)
 | |
| 	for i := 1; i < 200; i++ {
 | |
| 		reply.Answer = append(reply.Answer, test.A(fmt.Sprintf("large.example.com. 10 IN A 127.0.0.%d", i)))
 | |
| 	}
 | |
| 
 | |
| 	_, got := req.Scrub(reply)
 | |
| 	if want := ScrubAnswer; want != got {
 | |
| 		t.Errorf("want scrub result %d, got %d", want, got)
 | |
| 	}
 | |
| 	if want, got := req.Size(), reply.Len(); want < got {
 | |
| 		t.Errorf("want scrub to reduce message length below %d bytes, got %d bytes", want, got)
 | |
| 	}
 | |
| }
 | |
| 
 | |
| func TestRequestMatch(t *testing.T) {
 | |
| 	st := testRequest()
 | |
| 	reply := new(dns.Msg)
 | |
| 	reply.Response = true
 | |
| 
 | |
| 	reply.SetQuestion("example.com.", dns.TypeMX)
 | |
| 	if b := st.Match(reply); b {
 | |
| 		t.Errorf("failed to match %s %d, got %t, expected %t", "example.com.", dns.TypeMX, b, false)
 | |
| 	}
 | |
| 
 | |
| 	reply.SetQuestion("example.com.", dns.TypeA)
 | |
| 	if b := st.Match(reply); !b {
 | |
| 		t.Errorf("failed to match %s %d, got %t, expected %t", "example.com.", dns.TypeA, b, true)
 | |
| 	}
 | |
| 
 | |
| 	reply.SetQuestion("example.org.", dns.TypeA)
 | |
| 	if b := st.Match(reply); b {
 | |
| 		t.Errorf("failed to match %s %d, got %t, expected %t", "example.org.", dns.TypeA, b, false)
 | |
| 	}
 | |
| }
 | |
| 
 | |
| func BenchmarkRequestDo(b *testing.B) {
 | |
| 	st := testRequest()
 | |
| 
 | |
| 	for i := 0; i < b.N; i++ {
 | |
| 		st.Do()
 | |
| 	}
 | |
| }
 | |
| 
 | |
| func BenchmarkRequestSize(b *testing.B) {
 | |
| 	st := testRequest()
 | |
| 
 | |
| 	for i := 0; i < b.N; i++ {
 | |
| 		st.Size()
 | |
| 	}
 | |
| }
 | |
| 
 | |
| func testRequest() Request {
 | |
| 	m := new(dns.Msg)
 | |
| 	m.SetQuestion("example.com.", dns.TypeA)
 | |
| 	m.SetEdns0(4097, true)
 | |
| 	return Request{W: &test.ResponseWriter{}, Req: m}
 | |
| }
 |