mirror of
				https://github.com/coredns/coredns.git
				synced 2025-11-03 18:53:13 -05:00 
			
		
		
		
	Ignore invalid ServerBlockKeys in loop plugin that fail normalization. Retain the default “.” zone instead of indexing into an empty slice. This prevents an index-out-of-range panic triggered by malformed inputs such as "unix://". Added tests to validate and increase test coverage. Signed-off-by: Ville Vesilehto <ville@vesilehto.fi>
		
			
				
	
	
		
			94 lines
		
	
	
		
			1.8 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			94 lines
		
	
	
		
			1.8 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
package loop
 | 
						|
 | 
						|
import (
 | 
						|
	"net"
 | 
						|
	"strconv"
 | 
						|
	"time"
 | 
						|
 | 
						|
	"github.com/coredns/caddy"
 | 
						|
	"github.com/coredns/coredns/core/dnsserver"
 | 
						|
	"github.com/coredns/coredns/plugin"
 | 
						|
	"github.com/coredns/coredns/plugin/pkg/dnsutil"
 | 
						|
	"github.com/coredns/coredns/plugin/pkg/rand"
 | 
						|
)
 | 
						|
 | 
						|
func init() { plugin.Register("loop", setup) }
 | 
						|
 | 
						|
func setup(c *caddy.Controller) error {
 | 
						|
	l, err := parse(c)
 | 
						|
	if err != nil {
 | 
						|
		return plugin.Error("loop", err)
 | 
						|
	}
 | 
						|
 | 
						|
	dnsserver.GetConfig(c).AddPlugin(func(next plugin.Handler) plugin.Handler {
 | 
						|
		l.Next = next
 | 
						|
		return l
 | 
						|
	})
 | 
						|
 | 
						|
	// Send query to ourselves and see if it end up with us again.
 | 
						|
	c.OnStartup(func() error {
 | 
						|
		// Another Go function, otherwise we block startup and can't send the packet.
 | 
						|
		go func() {
 | 
						|
			deadline := time.Now().Add(30 * time.Second)
 | 
						|
			conf := dnsserver.GetConfig(c)
 | 
						|
			lh := ""
 | 
						|
			if len(conf.ListenHosts) > 0 {
 | 
						|
				lh = conf.ListenHosts[0]
 | 
						|
			}
 | 
						|
			addr := net.JoinHostPort(lh, conf.Port)
 | 
						|
 | 
						|
			for time.Now().Before(deadline) {
 | 
						|
				l.setAddress(addr)
 | 
						|
				if _, err := l.exchange(addr); err != nil {
 | 
						|
					l.reset()
 | 
						|
					time.Sleep(1 * time.Second)
 | 
						|
					continue
 | 
						|
				}
 | 
						|
 | 
						|
				go func() {
 | 
						|
					time.Sleep(2 * time.Second)
 | 
						|
					l.setDisabled()
 | 
						|
				}()
 | 
						|
 | 
						|
				break
 | 
						|
			}
 | 
						|
			l.setDisabled()
 | 
						|
		}()
 | 
						|
		return nil
 | 
						|
	})
 | 
						|
 | 
						|
	return nil
 | 
						|
}
 | 
						|
 | 
						|
func parse(c *caddy.Controller) (*Loop, error) {
 | 
						|
	i := 0
 | 
						|
	zones := []string{"."}
 | 
						|
	for c.Next() {
 | 
						|
		if i > 0 {
 | 
						|
			return nil, plugin.ErrOnce
 | 
						|
		}
 | 
						|
		i++
 | 
						|
		if c.NextArg() {
 | 
						|
			return nil, c.ArgErr()
 | 
						|
		}
 | 
						|
 | 
						|
		if len(c.ServerBlockKeys) > 0 {
 | 
						|
			z := plugin.Host(c.ServerBlockKeys[0]).NormalizeExact()
 | 
						|
			if len(z) > 0 {
 | 
						|
				zones = z
 | 
						|
			}
 | 
						|
		}
 | 
						|
	}
 | 
						|
	return New(zones[0]), nil
 | 
						|
}
 | 
						|
 | 
						|
// qname returns a random name. <rand.Int()>.<rand.Int().<zone>.
 | 
						|
func qname(zone string) string {
 | 
						|
	l1 := strconv.Itoa(r.Int())
 | 
						|
	l2 := strconv.Itoa(r.Int())
 | 
						|
 | 
						|
	return dnsutil.Join(l1, l2, zone)
 | 
						|
}
 | 
						|
 | 
						|
var r = rand.New(time.Now().UnixNano())
 |