mirror of
				https://github.com/coredns/coredns.git
				synced 2025-10-31 18:23:13 -04:00 
			
		
		
		
	* Document fallthrough and fix *reverse* While documenting the fallthrough behavior and testing it I noticed the did not properly work. This PR does a tiny bit too much as it - Documents fallthrough - Fixes fallthrough in reverse - Makes directives_generate complain on duplicate priorities - Moved reverse *before* file in middleware.cfg - Add a test that tests the reverse fallthrough behavior with a file backend Fixes #515 * ....and fix the tests
		
			
				
	
	
		
			146 lines
		
	
	
		
			3.3 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			146 lines
		
	
	
		
			3.3 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
| package reverse
 | |
| 
 | |
| import (
 | |
| 	"net"
 | |
| 	"regexp"
 | |
| 	"sort"
 | |
| 	"strconv"
 | |
| 	"strings"
 | |
| 
 | |
| 	"github.com/miekg/coredns/core/dnsserver"
 | |
| 	"github.com/miekg/coredns/middleware"
 | |
| 
 | |
| 	"github.com/mholt/caddy"
 | |
| )
 | |
| 
 | |
| func init() {
 | |
| 	caddy.RegisterPlugin("reverse", caddy.Plugin{
 | |
| 		ServerType: "dns",
 | |
| 		Action:     setupReverse,
 | |
| 	})
 | |
| }
 | |
| 
 | |
| func setupReverse(c *caddy.Controller) error {
 | |
| 	networks, fallThrough, err := reverseParse(c)
 | |
| 	if err != nil {
 | |
| 		return middleware.Error("reverse", err)
 | |
| 	}
 | |
| 
 | |
| 	dnsserver.GetConfig(c).AddMiddleware(func(next middleware.Handler) middleware.Handler {
 | |
| 		return Reverse{Next: next, Networks: networks, Fallthrough: fallThrough}
 | |
| 	})
 | |
| 
 | |
| 	return nil
 | |
| }
 | |
| 
 | |
| func reverseParse(c *caddy.Controller) (nets networks, fall bool, err error) {
 | |
| 
 | |
| 	// normalize zones, validation is almost done by dnsserver
 | |
| 	// TODO(miek): need sane helpers for these.
 | |
| 	zones := make([]string, len(c.ServerBlockKeys))
 | |
| 
 | |
| 	for i, str := range c.ServerBlockKeys {
 | |
| 		host, _, _ := net.SplitHostPort(str)
 | |
| 		zones[i] = strings.ToLower(host)
 | |
| 	}
 | |
| 
 | |
| 	for c.Next() {
 | |
| 		if c.Val() == "reverse" {
 | |
| 
 | |
| 			var cidrs []*net.IPNet
 | |
| 
 | |
| 			// parse all networks
 | |
| 			for _, cidr := range c.RemainingArgs() {
 | |
| 				if cidr == "{" {
 | |
| 					break
 | |
| 				}
 | |
| 				_, ipnet, err := net.ParseCIDR(cidr)
 | |
| 				if err != nil {
 | |
| 					return nil, false, c.Errf("network needs to be CIDR formatted: %q\n", cidr)
 | |
| 				}
 | |
| 				cidrs = append(cidrs, ipnet)
 | |
| 			}
 | |
| 			if len(cidrs) == 0 {
 | |
| 				return nil, false, c.ArgErr()
 | |
| 			}
 | |
| 
 | |
| 			// set defaults
 | |
| 			var (
 | |
| 				template = "ip-" + templateNameIP + ".{zone[1]}"
 | |
| 				ttl      = 60
 | |
| 			)
 | |
| 			for c.NextBlock() {
 | |
| 				switch c.Val() {
 | |
| 				case "hostname":
 | |
| 					if !c.NextArg() {
 | |
| 						return nil, false, c.ArgErr()
 | |
| 					}
 | |
| 					template = c.Val()
 | |
| 
 | |
| 				case "ttl":
 | |
| 					if !c.NextArg() {
 | |
| 						return nil, false, c.ArgErr()
 | |
| 					}
 | |
| 					ttl, err = strconv.Atoi(c.Val())
 | |
| 					if err != nil {
 | |
| 						return nil, false, err
 | |
| 					}
 | |
| 
 | |
| 				case "fallthrough":
 | |
| 					fall = true
 | |
| 
 | |
| 				default:
 | |
| 					return nil, false, c.ArgErr()
 | |
| 				}
 | |
| 			}
 | |
| 
 | |
| 			// prepare template
 | |
| 			// replace {zone[index]} by the listen zone/domain of this config block
 | |
| 			for i, zone := range zones {
 | |
| 				// TODO: we should be smarter about actually replacing this. This works, but silently allows "zone[-1]"
 | |
| 				// for instance.
 | |
| 				template = strings.Replace(template, "{zone["+strconv.Itoa(i+1)+"]}", zone, 1)
 | |
| 			}
 | |
| 			if !strings.HasSuffix(template, ".") {
 | |
| 				template += "."
 | |
| 			}
 | |
| 
 | |
| 			// extract zone from template
 | |
| 			templateZone := strings.SplitAfterN(template, ".", 2)
 | |
| 			if len(templateZone) != 2 || templateZone[1] == "" {
 | |
| 				return nil, false, c.Errf("cannot find domain in template '%v'", template)
 | |
| 			}
 | |
| 
 | |
| 			// Create for each configured network in this stanza
 | |
| 			for _, ipnet := range cidrs {
 | |
| 				// precompile regex for hostname to ip matching
 | |
| 				regexIP := regexMatchV4
 | |
| 				if ipnet.IP.To4() == nil {
 | |
| 					regexIP = regexMatchV6
 | |
| 				}
 | |
| 				regex, err := regexp.Compile(
 | |
| 					"^" + strings.Replace( // inject ip regex into template
 | |
| 						regexp.QuoteMeta(template), // escape dots
 | |
| 						regexp.QuoteMeta(templateNameIP),
 | |
| 						regexIP,
 | |
| 						1) + "$")
 | |
| 				if err != nil {
 | |
| 					return nil, false, err
 | |
| 				}
 | |
| 
 | |
| 				nets = append(nets, network{
 | |
| 					IPnet:        ipnet,
 | |
| 					Zone:         templateZone[1],
 | |
| 					Template:     template,
 | |
| 					RegexMatchIP: regex,
 | |
| 					TTL:          uint32(ttl),
 | |
| 				})
 | |
| 			}
 | |
| 		}
 | |
| 	}
 | |
| 
 | |
| 	// sort by cidr
 | |
| 	sort.Sort(nets)
 | |
| 	return nets, fall, nil
 | |
| }
 |